Michael Han commented on ZOOKEEPER-761:

Single threaded API seems to be useful for certain use cases reported on 
mailing list besides historical reasons for supporting FreeBSD 4.X :-) - such 
as embedding ZK in certain runtimes like node/libuv where single thread is a 
natural fit. Deprecating single threaded api might impact those cases but there 
should be workaround (i.e. a pure javascript client for node.js instead of 
embedding zk).

> Remove *synchronous* calls from the *single-threaded* C clieant API, since 
> they are documented not to work
> ----------------------------------------------------------------------------------------------------------
>                 Key: ZOOKEEPER-761
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-761
>             Project: ZooKeeper
>          Issue Type: Improvement
>          Components: c client
>    Affects Versions: 3.1.1, 3.2.2
>         Environment: RHEL 4u8 (Linux).  The issue is not OS-specific though.
>            Reporter: Jozef Hatala
>            Assignee: Pierre Habouzit
>            Priority: Minor
>             Fix For: 3.5.3, 3.6.0
>         Attachments: fix-sync-apis-in-st-adaptor.patch, 
> fix-sync-apis-in-st-adaptor.v2.patch
> Since the synchronous calls are 
> [known|http://hadoop.apache.org/zookeeper/docs/current/zookeeperProgrammers.html#Using+the+C+Client]
>  to be unimplemented in the single threaded version of the client library 
> libzookeeper_st.so, I believe that it would be helpful towards users of the 
> library if that information was also obvious from the header file.
> Anecdotally more than one of us here made the mistake of starting by using 
> the synchronous calls with the single-threaded library, and we found 
> ourselves debugging it.  An early warning would have been greatly appreciated.
> 1. Could you please add warnings to the doxygen blocks of all synchronous 
> calls saying that they are not available in the single-threaded API.  This 
> cannot be safely done with {{#ifdef THREADED}}, obviously, because the same 
> header file is included whichever client library implementation one is 
> compiling for.
> 2. Could you please bracket the implementation of all synchronous calls in 
> zookeeper.c with {{#ifdef THREADED}} and {{#endif}}, so that those symbols 
> are not present in libzookeeper_st.so?

This message was sent by Atlassian JIRA

Reply via email to