[ https://issues.apache.org/jira/browse/ZOOKEEPER-2479?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15633784#comment-15633784 ]
ASF GitHub Bot commented on ZOOKEEPER-2479: ------------------------------------------- Github user eribeiro commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/98#discussion_r86415195 --- Diff: src/java/main/org/apache/zookeeper/server/quorum/QuorumPeer.java --- @@ -520,6 +520,12 @@ public synchronized void setCurrentVote(Vote v){ protected boolean quorumListenOnAllIPs = false; /** + * Keeps time taken for leader election in milliseconds. Sets the value to + * this variable only after the completion of leader election. + */ + private long electionTimeTaken = -1; --- End diff -- sincere question: does it make sense to make this field `volatile`? I know there are some concurrency guarantees but not sure if it's worth change it. > Add 'electionTimeTaken' value in LeaderMXBean and FollowerMXBean > ---------------------------------------------------------------- > > Key: ZOOKEEPER-2479 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2479 > Project: ZooKeeper > Issue Type: Improvement > Components: quorum > Reporter: Rakesh R > Assignee: Rakesh R > Fix For: 3.4.10, 3.5.3, 3.6.0 > > Attachments: ZOOKEEPER-2479.patch, ZOOKEEPER-2479.patch, > ZOOKEEPER-2479.patch, ZOOKEEPER-2479.patch, ZOOKEEPER-2479.patch, > ZOOKEEPER-2479.patch > > > The idea of this jira is to expose {{time taken}} for the leader election via > jmx Leader, Follower beans. -- This message was sent by Atlassian JIRA (v6.3.4#6332)