[ https://issues.apache.org/jira/browse/ZOOKEEPER-2479?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15675883#comment-15675883 ]
ASF GitHub Bot commented on ZOOKEEPER-2479: ------------------------------------------- Github user rgs1 commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/98#discussion_r88602850 --- Diff: src/java/test/org/apache/zookeeper/test/QuorumMajorityTest.java --- @@ -36,7 +38,30 @@ /***************************************************************/ @Test public void testMajQuorums() throws Throwable { - + LOG.info("Verify QuorumPeer#electionTimeTaken jmx bean attribute"); + + ArrayList<QuorumPeer> peers = getPeerList(); + for (int i = 1; i <= peers.size(); i++) { + QuorumPeer qp = peers.get(i - 1); + Long electionTimeTaken = -1L; + String bean = ""; + if (qp.getPeerState() == ServerState.FOLLOWING) { + bean = CommonNames.DOMAIN + ":name0=ReplicatedServer_id" + i + + ",name1=replica." + i + ",name2=Follower"; + electionTimeTaken = (Long) JMXEnv.ensureBeanAttribute(bean, + "ElectionTimeTaken"); + Assert.assertTrue("Wrong electionTimeTaken value!", + electionTimeTaken >= 0); + } else if (qp.getPeerState() == ServerState.LEADING) { + bean = CommonNames.DOMAIN + ":name0=ReplicatedServer_id" + i + + ",name1=replica." + i + ",name2=Leader"; --- End diff -- ditto > Add 'electionTimeTaken' value in LeaderMXBean and FollowerMXBean > ---------------------------------------------------------------- > > Key: ZOOKEEPER-2479 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2479 > Project: ZooKeeper > Issue Type: Improvement > Components: quorum > Reporter: Rakesh R > Assignee: Rakesh R > Fix For: 3.4.10, 3.5.3, 3.6.0 > > Attachments: ZOOKEEPER-2479.patch, ZOOKEEPER-2479.patch, > ZOOKEEPER-2479.patch, ZOOKEEPER-2479.patch, ZOOKEEPER-2479.patch, > ZOOKEEPER-2479.patch > > > The idea of this jira is to expose {{time taken}} for the leader election via > jmx Leader, Follower beans. -- This message was sent by Atlassian JIRA (v6.3.4#6332)