[ https://issues.apache.org/jira/browse/ZOOKEEPER-2642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15751215#comment-15751215 ]
ASF GitHub Bot commented on ZOOKEEPER-2642: ------------------------------------------- Github user Randgalt commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/122#discussion_r92597402 --- Diff: src/java/main/org/apache/zookeeper/ZooKeeper.java --- @@ -39,32 +39,10 @@ import org.apache.zookeeper.client.ZKClientConfig; import org.apache.zookeeper.client.ZooKeeperSaslClient; import org.apache.zookeeper.common.PathUtils; +import org.apache.zookeeper.common.StringUtils; import org.apache.zookeeper.data.ACL; import org.apache.zookeeper.data.Stat; -import org.apache.zookeeper.proto.CheckWatchesRequest; -import org.apache.zookeeper.proto.Create2Response; -import org.apache.zookeeper.proto.CreateRequest; -import org.apache.zookeeper.proto.CreateResponse; -import org.apache.zookeeper.proto.CreateTTLRequest; -import org.apache.zookeeper.proto.DeleteRequest; -import org.apache.zookeeper.proto.ExistsRequest; -import org.apache.zookeeper.proto.GetACLRequest; -import org.apache.zookeeper.proto.GetACLResponse; -import org.apache.zookeeper.proto.GetChildren2Request; -import org.apache.zookeeper.proto.GetChildren2Response; -import org.apache.zookeeper.proto.GetChildrenRequest; -import org.apache.zookeeper.proto.GetChildrenResponse; -import org.apache.zookeeper.proto.GetDataRequest; -import org.apache.zookeeper.proto.GetDataResponse; -import org.apache.zookeeper.proto.RemoveWatchesRequest; -import org.apache.zookeeper.proto.ReplyHeader; -import org.apache.zookeeper.proto.RequestHeader; -import org.apache.zookeeper.proto.SetACLRequest; -import org.apache.zookeeper.proto.SetACLResponse; -import org.apache.zookeeper.proto.SetDataRequest; -import org.apache.zookeeper.proto.SetDataResponse; -import org.apache.zookeeper.proto.SyncRequest; -import org.apache.zookeeper.proto.SyncResponse; +import org.apache.zookeeper.proto.*; --- End diff -- fixed > ZOOKEEPER-2014 breaks existing clients for little benefit > --------------------------------------------------------- > > Key: ZOOKEEPER-2642 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2642 > Project: ZooKeeper > Issue Type: Bug > Components: c client, java client > Affects Versions: 3.5.2 > Reporter: Jordan Zimmerman > Assignee: Jordan Zimmerman > Priority: Blocker > Attachments: ZOOKEEPER-2642.patch, ZOOKEEPER-2642.patch, > ZOOKEEPER-2642.patch > > > ZOOKEEPER-2014 moved the reconfig() methods into a new class, ZooKeeperAdmin. > It appears this was done to document that these are methods have access > restrictions. However, this change breaks Apache Curator (and possibly other > clients). Curator APIs will have to be changed and/or special methods need to > be added. A breaking change of this kind should only be done when the benefit > is overwhelming. In this case, the same information can be conveyed with > documentation and possibly a deprecation notice. > Revert the creation of the ZooKeeperAdmin class and move the reconfig() > methods back to the ZooKeeper class with additional documentation. -- This message was sent by Atlassian JIRA (v6.3.4#6332)