Github user eribeiro commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/120#discussion_r95709489
--- Diff:
src/java/main/org/apache/zookeeper/server/persistence/FileTxnSnapLog.java ---
@@ -167,6 +175,16 @@ public long restore(DataTree dt, Map<Long, Integer>
sessions,
PlayBackListener listener) throws IOException {
long deserializeResult = snapLog.deserialize(dt, sessions);
FileTxnLog txnLog = new FileTxnLog(dataDir);
+ boolean suspectEmptyDB;
--- End diff --
Could we rename this to `recoveringDB` or `recoveringNode`?
My rationale is: `suspectEmptyDB` looks vague to me, **plus** __if I
understood it right__ a node could have been shutdown and restarted after some
time. So, not necessarily its DB will be empty, but it is in a recovering
process so we want to avoid that it becoming the leader and messing up with
transactions performed while it was offline, right?
Could we rename this to `recoveringDB` or `recoveringNode`?
My rationale is: `suspectEmptyDB` looks vague to me, **plus** because __if
I understood it right__ a node could have been shutdown and restarted after
some time. So, not necessarily its DB will be empty, but it is in a recovering
process so we want to avoid that it becoming the leader and messing up with
transactions performed while it was offline, right?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
