Github user eribeiro commented on a diff in the pull request:

    https://github.com/apache/zookeeper/pull/120#discussion_r95703179
  
    --- Diff: bin/zkServer-initialize.sh ---
    @@ -113,6 +113,8 @@ initialize() {
         else
             echo "No myid provided, be sure to specify it in $ZOO_DATADIR/myid 
if using non-standalone"
         fi
    +
    +    date > "$ZOO_DATADIR/initialize"
    --- End diff --
    
    Nit: If the sole purpose of this file is to act as a marker, in spite of 
its content,  then a 
    
    ```touch $ZOO_DATADIR/initialize``` 
    
    would be enough, wouldn't it?
    
    Of course, `date` is fine as well, no problem.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to