Github user enixon commented on a diff in the pull request:

    https://github.com/apache/zookeeper/pull/120#discussion_r95866724
  
    --- Diff: 
src/java/main/org/apache/zookeeper/server/persistence/FileTxnSnapLog.java ---
    @@ -167,6 +175,16 @@ public long restore(DataTree dt, Map<Long, Integer> 
sessions,
                 PlayBackListener listener) throws IOException {
             long deserializeResult = snapLog.deserialize(dt, sessions);
             FileTxnLog txnLog = new FileTxnLog(dataDir);
    +        boolean suspectEmptyDB;
    --- End diff --
    
    If `suspectEmptyDB` looks vague to you, that's enough reason to change it. 
The intent is to capture "if you find can't find a data base then treat that 
condition with paranoia and don't vote until someone provides you with one". 
The recovery aspect could be emphasized with `forceRecoverEmptyDB`. Or we could 
invert the condition and call it `trustEmptyDB`. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to