[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15823406#comment-15823406
 ] 

ASF GitHub Bot commented on ZOOKEEPER-2659:
-------------------------------------------

Github user jvz commented on a diff in the pull request:

    https://github.com/apache/zookeeper/pull/148#discussion_r96145218
  
    --- Diff: conf/log4j2.xml ---
    @@ -0,0 +1,56 @@
    +<?xml version="1.0" encoding="UTF-8" ?>
    +<!-- All loggers are Async if
    +    
-DLog4jContextSelector=org.apache.logging.log4j.core.async.AsyncLoggerContextSelector
 if is set -->
    +<Configuration status="warn" strict="true">
    +  <Properties>
    +    <Property name="consoleLayoutPattern">%d{ISO8601} [myid:%X{myid}] - 
%-5p [%t:%C{1}@%L] - %m%n</Property>
    --- End diff --
    
    I'd generally advise against [enabling location 
information](http://logging.apache.org/log4j/2.x/manual/layouts.html#LocationInformation)
 by default due to performance issues. I personally don't find location 
information all that useful outside of caught exceptions anyways.


> Use log4j2 as a logging framework as log4j 1.X is now deprecated
> ----------------------------------------------------------------
>
>                 Key: ZOOKEEPER-2659
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2659
>             Project: ZooKeeper
>          Issue Type: Wish
>            Reporter: Pushkar Raste
>            Priority: Minor
>         Attachments: zk_log4j2_migration.patch
>
>
> Zookeeper currently uses {{log4j 1.X}} as the default logging framework. 
> {{log4j 1.X}} is now deprecated http://logging.apache.org/log4j/1.2/
> This ticket is to track efforts to move zookeeper to {{log4j2}}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to