[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15824813#comment-15824813
 ] 

ASF GitHub Bot commented on ZOOKEEPER-2659:
-------------------------------------------

Github user jvz commented on a diff in the pull request:

    https://github.com/apache/zookeeper/pull/148#discussion_r96329244
  
    --- Diff: ivy.xml ---
    @@ -41,13 +41,20 @@
     
       <dependencies>
         <dependency org="org.slf4j" name="slf4j-api" rev="1.7.5"/>
    -    <dependency org="org.slf4j" name="slf4j-log4j12" rev="1.7.5" 
transitive="false"/>
    +    
    +    <dependency org="org.apache.logging.log4j" name="log4j-api" rev="2.7" 
transitive="false"/>
    +    <dependency org="org.apache.logging.log4j" name="log4j-core" rev="2.7" 
transitive="false"/>
    +    <dependency org="org.apache.logging.log4j" name="log4j-slf4j-impl" 
rev="2.7" transitive="false"/>
    +
    +    <!-- disruptor for Async loggers -->    
    +    <dependency org="com.lmax" name="disruptor" rev="3.3.0" 
transitive="false"/>
    +    
         <dependency org="commons-cli" name="commons-cli" rev="1.2" />
       
         <dependency org="org.apache.maven.wagon" name="wagon-http" rev="2.4" 
conf="mvn-ant-task->default"/>
         <dependency org="org.apache.maven" name="maven-ant-tasks" rev="2.1.3" 
conf="mvn-ant-task->master"/>
         <!-- transitive false turns off dependency checking, log4j deps seem 
borked -->
    -    <dependency org="log4j" name="log4j" rev="1.2.17" transitive="false"/>
    +    <!-- dependency org="log4j" name="log4j" rev="1.2.17" 
transitive="false"/ -->
    --- End diff --
    
    Agreed, just pointing out in case anything is still using the old API.


> Use log4j2 as a logging framework as log4j 1.X is now deprecated
> ----------------------------------------------------------------
>
>                 Key: ZOOKEEPER-2659
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2659
>             Project: ZooKeeper
>          Issue Type: Wish
>            Reporter: Pushkar Raste
>            Priority: Minor
>         Attachments: zk_log4j2_migration.patch
>
>
> Zookeeper currently uses {{log4j 1.X}} as the default logging framework. 
> {{log4j 1.X}} is now deprecated http://logging.apache.org/log4j/1.2/
> This ticket is to track efforts to move zookeeper to {{log4j2}}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to