Github user kfirlevari commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/167#discussion_r100684179
--- Diff:
src/java/test/org/apache/zookeeper/server/quorum/CommitProcessorConcurrencyTest.java
---
@@ -374,4 +372,52 @@ public void noStarvationOfReadRequestsTest() throws
Exception {
!processedRequests.contains(r));
}
}
+
+ /**
+ * In the following test, we verify that we can handle the case that
we got a commit
+ * of a request we never seen since the session that we just
established. This can happen
+ * when a session is just established and there is request waiting to
be commited in the
+ * in the session queue but it sees a commit for a request in the
previous connection
+ */
+ @Test(timeout = 1000)
+ public void noCrashOnCommittedRequestsOfUnSeenRequestTest() throws
Exception {
+ final String path =
"/noCrash/OnCommittedRequests/OfUnSeenRequestTest";
+ final int iteration = 10;
--- End diff --
Not sure about the meaning of "iteration". It is used both for the loop and
for setting number of threads.. can you init number of threads as in other
tests? (it's not relevant after all to the tested functionality).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
