Github user hanm commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/167#discussion_r100685238
--- Diff:
src/java/test/org/apache/zookeeper/server/quorum/CommitProcessorConcurrencyTest.java
---
@@ -106,6 +106,7 @@ public void shutdown() {
@Override
public void notifyStopping(String threadName, int
errorCode) {
+ Assert.fail("Commit processor crashed " + errorCode);
--- End diff --
I think the two commits are different - they changed different part of
code. It is indeed confusing because they share same commit message, which is
better to be fixed via git amend, but in our case it is also fine to leave them
as they are because when merge the pull request the committer will squash the
commits into a single commit anyway.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
