[
https://issues.apache.org/jira/browse/ZOOKEEPER-2732?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15982132#comment-15982132
]
Hadoop QA commented on ZOOKEEPER-2732:
--------------------------------------
-1 overall. GitHub Pull Request Build
+1 @author. The patch does not contain any @author tags.
+0 tests included. The patch appears to be a documentation patch that
doesn't require tests.
-1 javadoc. The javadoc tool appears to have generated 1 warning messages.
+1 javac. The applied patch does not increase the total number of javac
compiler warnings.
-1 findbugs. The patch appears to introduce 83 new Findbugs (version
3.0.1) warnings.
+1 release audit. The applied patch does not increase the total number of
release audit warnings.
-1 core tests. The patch failed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/599//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/599//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/599//console
This message is automatically generated.
> Cleanup findbug warnings in branch-3.4: Performance Warnings
> ------------------------------------------------------------
>
> Key: ZOOKEEPER-2732
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2732
> Project: ZooKeeper
> Issue Type: Sub-task
> Reporter: Rakesh R
> Assignee: Abraham Fine
> Fix For: 3.4.11
>
>
> Please refer the attached sheet in parent jira. Below is the details of
> findbug warnings.
> {code}
> Bx Boxing/unboxing to parse a primitive new
> org.apache.zookeeper.server.quorum.QuorumCnxManager(long, Map,
> QuorumAuthServer, QuorumAuthLearner, int, boolean, int, boolean)
> Bx new org.apache.zookeeper.server.quorum.QuorumCnxManager(long, Map,
> QuorumAuthServer, QuorumAuthLearner, int, boolean, int, boolean) invokes
> inefficient new Integer(String) constructor; use Integer.valueOf(String)
> instead
> Dm
> org.apache.zookeeper.server.quorum.FastLeaderElection$Notification.toString()
> invokes inefficient new String(String) constructor
> WMI org.apache.zookeeper.server.DataTree.dumpEphemerals(PrintWriter) makes
> inefficient use of keySet iterator instead of entrySet iterator
> WMI
> org.apache.zookeeper.server.quorum.flexible.QuorumHierarchical.computeGroupWeight()
> makes inefficient use of keySet iterator instead of entrySet iterator
> WMI
> org.apache.zookeeper.server.quorum.flexible.QuorumHierarchical.containsQuorum(HashSet)
> makes inefficient use of keySet iterator instead of entrySet iterator
> WMI org.apache.zookeeper.ZooKeeperMain.usage() makes inefficient use of
> keySet iterator instead of entrySet iterator
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
