[
https://issues.apache.org/jira/browse/ZOOKEEPER-2732?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16016451#comment-16016451
]
ASF GitHub Bot commented on ZOOKEEPER-2732:
-------------------------------------------
GitHub user afine opened a pull request:
https://github.com/apache/zookeeper/pull/258
ZOOKEEPER-2732: Cleanup findbug warnings in branch-3.4: Performance Warnings
@rakeshadr Apologies for recreating this, I accidentally pushed a bad
branch in https://github.com/apache/zookeeper/pull/231 and GitHub will not let
me reset the head for that PR. This should be rebased and ready to be merged.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/afine/zookeeper ZOOKEEPER-2732
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zookeeper/pull/258.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #258
----
commit 7509f69e95749b30ba06fb224750bbb5cd487547
Author: Abraham Fine <af...@apache.org>
Date: 2017-04-18T18:40:12Z
ZOOKEEPER-2732: Cleanup findbug warnings in branch-3.4: Performance Warnings
----
> Cleanup findbug warnings in branch-3.4: Performance Warnings
> ------------------------------------------------------------
>
> Key: ZOOKEEPER-2732
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2732
> Project: ZooKeeper
> Issue Type: Sub-task
> Reporter: Rakesh R
> Assignee: Abraham Fine
> Fix For: 3.4.11
>
>
> Please refer the attached sheet in parent jira. Below is the details of
> findbug warnings.
> {code}
> Bx Boxing/unboxing to parse a primitive new
> org.apache.zookeeper.server.quorum.QuorumCnxManager(long, Map,
> QuorumAuthServer, QuorumAuthLearner, int, boolean, int, boolean)
> Bx new org.apache.zookeeper.server.quorum.QuorumCnxManager(long, Map,
> QuorumAuthServer, QuorumAuthLearner, int, boolean, int, boolean) invokes
> inefficient new Integer(String) constructor; use Integer.valueOf(String)
> instead
> Dm
> org.apache.zookeeper.server.quorum.FastLeaderElection$Notification.toString()
> invokes inefficient new String(String) constructor
> WMI org.apache.zookeeper.server.DataTree.dumpEphemerals(PrintWriter) makes
> inefficient use of keySet iterator instead of entrySet iterator
> WMI
> org.apache.zookeeper.server.quorum.flexible.QuorumHierarchical.computeGroupWeight()
> makes inefficient use of keySet iterator instead of entrySet iterator
> WMI
> org.apache.zookeeper.server.quorum.flexible.QuorumHierarchical.containsQuorum(HashSet)
> makes inefficient use of keySet iterator instead of entrySet iterator
> WMI org.apache.zookeeper.ZooKeeperMain.usage() makes inefficient use of
> keySet iterator instead of entrySet iterator
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
