ASF GitHub Bot commented on ZOOKEEPER-2870:

GitHub user lvfangmin opened a pull request:


    [ZOOKEEPER-2870] Improve the efficiency of AtomicFileOutputStream


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/lvfangmin/zookeeper ZOOKEEPER-2870

Alternatively you can review and apply these changes as the patch at:


To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #331
commit 7154ccd9c0fa489b070645ba3bcfc4c9e25d4683
Author: Fangmin Lyu <allen...@fb.com>
Date:   2017-08-09T20:01:02Z

    [ZOOKEEPER-2870] Improve the efficiency of AtomicFileOutputStream


> Improve the efficiency of AtomicFileOutputStream
> ------------------------------------------------
>                 Key: ZOOKEEPER-2870
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2870
>             Project: ZooKeeper
>          Issue Type: Improvement
>          Components: server
>    Affects Versions: 3.4.10, 3.5.3, 3.6.0
>            Reporter: Fangmin Lv
>            Assignee: Fangmin Lv
> The AtomicFileOutputStream extends from FilterOutputStream, where the write 
> function writes data to underlying stream byte by byte: 
> https://searchcode.com/codesearch/view/17990706/, which is very inefficient. 
> Currently, we only this this class to write the dynamic config, because it's 
> quite small it won't be a big problem. But in the future we may want to use 
> this class to write the snapshot file, which will take much longer time, 
> tested inside, writing 600MB snapshot will take more than 10 minutes, while 
> using FileOutputStream directly only takes 6s.

This message was sent by Atlassian JIRA

Reply via email to