[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2870?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16122255#comment-16122255
 ] 

ASF GitHub Bot commented on ZOOKEEPER-2870:
-------------------------------------------

Github user hanm commented on the issue:

    https://github.com/apache/zookeeper/pull/331
  
    Committed to master: 
https://github.com/apache/zookeeper/commit/0c5b320060bdda854b530dc8a22993ba8cbbd655
    3.5: 
https://github.com/apache/zookeeper/commit/c815380191ac300410d5f017cb4946b442e1dd65
    3.4: 
https://github.com/apache/zookeeper/commit/9959b0e4387c02e82fadb0aee8d59f6212a2757e


> Improve the efficiency of AtomicFileOutputStream
> ------------------------------------------------
>
>                 Key: ZOOKEEPER-2870
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2870
>             Project: ZooKeeper
>          Issue Type: Improvement
>          Components: server
>    Affects Versions: 3.4.10, 3.5.3, 3.6.0
>            Reporter: Fangmin Lv
>            Assignee: Fangmin Lv
>             Fix For: 3.5.4, 3.6.0, 3.4.11
>
>
> The AtomicFileOutputStream extends from FilterOutputStream, where the write 
> function writes data to underlying stream byte by byte: 
> https://searchcode.com/codesearch/view/17990706/, which is very inefficient. 
> Currently, we only this this class to write the dynamic config, because it's 
> quite small it won't be a big problem. But in the future we may want to use 
> this class to write the snapshot file, which will take much longer time, 
> tested inside, writing 600MB snapshot will take more than 10 minutes, while 
> using FileOutputStream directly only takes 6s.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to