[
https://issues.apache.org/jira/browse/ZOOKEEPER-2809?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16150411#comment-16150411
]
ASF GitHub Bot commented on ZOOKEEPER-2809:
-------------------------------------------
GitHub user mfenes opened a pull request:
https://github.com/apache/zookeeper/pull/355
ZOOKEEPER-2809: Unnecessary stack-trace in server when the client dis…
Unnecessary stack-trace in server when the client disconnects unexpectedly.
Backport from master, branch-3.5 to branch-3.4. Removes unnecessary stack
traces from the catch blocks of method doIO in NIOServerCnxn. For
EndOfStreamException stack trace is replaced with logging only the message and
also contains the removal of stack traces for exceptions CancelledKeyException
and IOException as per commit 6206b495 referenced in the ticket.
This change is necessary as there are projects which consider all stack
traces as bugs.
For CancelledKeyException and IOException developers are still able to see
stack traces at log level Debug.
This change is in sync with master and branch-3.5.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mfenes/zookeeper ZOOKEEPER-2809
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zookeeper/pull/355.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #355
----
commit 81cd3cc42d85371bd24e427bedab1740695be819
Author: Mark Fenes <[email protected]>
Date: 2017-08-31T12:11:09Z
ZOOKEEPER-2809: Unnecessary stack-trace in server when the client
disconnect unexpectedly
----
> Unnecessary stack-trace in server when the client disconnect unexpectedly
> -------------------------------------------------------------------------
>
> Key: ZOOKEEPER-2809
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2809
> Project: ZooKeeper
> Issue Type: Bug
> Components: server
> Affects Versions: 3.4.8
> Reporter: Paul Millar
> Assignee: Mark Fenes
> Priority: Minor
> Fix For: 3.5.0
>
>
> In ZK 3.4.x, if the client disconnects unexpectedly then the server logs this
> with a stack-trace (see
> src/java/main/org/apache/zookeeper/server/NIOServerCnxn.java:356).
> This is unfortunate as we are using an embedded ZK server in our project (in
> a test environment) and we consider all stack-traces as bugs.
> I noticed that ZK 3.5 and later no longer log a stack-trace. This change is
> due to commit 6206b495 (in branch-3.5), which adds ZOOKEEPER-1504 and seems
> to fix this issue almost as a side-effect; a similar change in master has the
> same effect.
> I was wondering if the change in how EndOfStreamException is logged (i.e.,
> logging the message without a stack-trace) could be back-ported to 3.4
> branch, so could be included in the next 3.4 release.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
