[
https://issues.apache.org/jira/browse/ZOOKEEPER-2809?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16153740#comment-16153740
]
ASF GitHub Bot commented on ZOOKEEPER-2809:
-------------------------------------------
Github user mfenes commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/355#discussion_r137005402
--- Diff: src/java/main/org/apache/zookeeper/server/NIOServerCnxn.java ---
@@ -374,14 +373,12 @@ void doIO(SelectionKey k) throws InterruptedException
{
// expecting close to log session closure
close();
} catch (EndOfStreamException e) {
- LOG.warn("caught end of stream exception",e); // tell user why
-
+ LOG.warn(e.getMessage());
--- End diff --
Yes, it would make sense to log the stack trace at debug level for
EndOfStreamException too, so that we don't get less information in the log
after this change is applied. The reason why I did not include it first, was to
keep this change a pure backport from master and branch-3.5 to branch-3.4 as
the original change does not include this additional logging statement. I've
added it now, but probably then we should also add it to master as well if we
wish to keep it.
> Unnecessary stack-trace in server when the client disconnect unexpectedly
> -------------------------------------------------------------------------
>
> Key: ZOOKEEPER-2809
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2809
> Project: ZooKeeper
> Issue Type: Bug
> Components: server
> Affects Versions: 3.4.8
> Reporter: Paul Millar
> Assignee: Mark Fenes
> Priority: Minor
> Fix For: 3.5.0
>
>
> In ZK 3.4.x, if the client disconnects unexpectedly then the server logs this
> with a stack-trace (see
> src/java/main/org/apache/zookeeper/server/NIOServerCnxn.java:356).
> This is unfortunate as we are using an embedded ZK server in our project (in
> a test environment) and we consider all stack-traces as bugs.
> I noticed that ZK 3.5 and later no longer log a stack-trace. This change is
> due to commit 6206b495 (in branch-3.5), which adds ZOOKEEPER-1504 and seems
> to fix this issue almost as a side-effect; a similar change in master has the
> same effect.
> I was wondering if the change in how EndOfStreamException is logged (i.e.,
> logging the message without a stack-trace) could be back-ported to 3.4
> branch, so could be included in the next 3.4 release.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
