Github user phunt commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/443#discussion_r163712079
--- Diff: build.xml ---
@@ -1406,50 +1410,53 @@
xmlns:cs="antlib:com.puppycrawl.tools.checkstyle.ant">
<target name="test-core" depends="test-core-java, test-core-cppunit"/>
+ <target name="test-coverage-java">
--- End diff --
"I think declaring a "test-coverage-java" target to run Clover does not
mean "coverage" == clover. The fact that it currently calls "test-core-java"
and "generate-clover-reports" does not mean that we would not allow anybody to
add/use other code coverage tools here."
Notice how we have cobertura down below in the build.xml file. This is what
I mean. "test-coverage-java" just calls clover. If we had created a
"test-coverage-java" in the past that called cobertura it seems like that's a
statement. It's not a big deal, but hopefully you see what I mean.
Renaming to be more clover specific seems reasonable to me.
---
