Github user mfenes commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/443#discussion_r163218498
--- Diff: build.xml ---
@@ -132,21 +169,16 @@ xmlns:cs="antlib:com.puppycrawl.tools.checkstyle.ant">
<property name="ant_task_repo_url"
value="${mvnrepo}${tsk.org}${ant-task.version}/maven-ant-tasks-${ant-task.version}.jar"/>
<property name="ant_task.jar"
location="${ivy.lib}/maven-ant-tasks-${ant-task.version}.jar"/>
-
- <available property="clover.present"
- classname="com.cenqua.clover.CloverInstr"
- classpath="${clover.home}/lib/clover.jar"/>
- <available file="${c.src.dir}/Makefile" property="Makefile.present"/>
-
- <!-- check if clover reports should be generated -->
- <condition property="clover.enabled">
- <and>
- <isset property="run.clover"/>
- <isset property="clover.present"/>
- </and>
- </condition>
+ <!-- clover property set -->
+ <property name="clover.home" location="${test.java.build.dir}"/>
--- End diff --
The main reason why I set clover.home to ${test.java.build.dir} is because
originally in master, 3.5 and 3.4 Clover db is set to
${test.java.build.dir}/clover/db and Clover reports are set to
${test.java.build.dir}/clover/reports. This indicates that clover.home should
be ${test.java.build.dir}. Since Clover was in use before this change, I
thought it's better to keep the original settings as other tools (e.g. a
Jenkins job) might rely on reports being generated under this location.
@anmolnar also recommended to use this setting in his comment. Setting
clover.home to ${test.java.build.dir} does not put everything related to Clover
directly under build/test, as Clover db goes into build/test/clover/db, Clover
reports go under build/test/clover/reports and clover jar is placed in
/build/test/lib. Of course, I can change clover.home to point to any other
location, e.g. to build/coverage, but one reason against it might be that
Clover code coverage is more related to test than to bui
ld.
---
