Github user anmolnar commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/453#discussion_r168793211 --- Diff: src/java/test/org/apache/zookeeper/server/quorum/QuorumPeerMainTest.java --- @@ -435,7 +435,7 @@ private void waitForOne(ZooKeeper zk, States state) throws InterruptedException int iterations = ClientBase.CONNECTION_TIMEOUT / 500; while (zk.getState() != state) { if (iterations-- == 0) { - throw new RuntimeException("Waiting too long"); + throw new RuntimeException("Waiting too long " + zk.getState() + " != " + state); --- End diff -- Although I agree with you in general, I think this one here is a good addition to test output.
---