[
https://issues.apache.org/jira/browse/ZOOKEEPER-2399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16377335#comment-16377335
]
William L Thomson Jr commented on ZOOKEEPER-2399:
-------------------------------------------------
Turns out it was not to bad, and really does not seem like anything has changed
in those classes since I did the work. The rebase conflicts were minor. Just
removing old code, in place of new really. This time I uploaded the changes to
a netty4 branch
https://github.com/Obsidian-StudiosInc/zookeeper/tree/netty4
Patch format
https://github.com/Obsidian-StudiosInc/zookeeper/commit/d97cda5b944ed57136841b3dd27312be818d668d.patch
Diff format
https://github.com/Obsidian-StudiosInc/zookeeper/commit/d97cda5b944ed57136841b3dd27312be818d668d.diff
Those should cleanly apply, but still needs work. Aspects of Zookeeper may need
recoding for Netty 4.x. Pretty sure I was using Netty 4.1.x, not 4.0.x. No
point to 4.0.x IMHO, best to go to 4.1.x. Rather than 3.x, which it currently
uses from org.jboss.netty, pre netty.io starting in 4.x.
> Partial Initial Patches to update Zookeeper trunk to Netty 4.x API
> ------------------------------------------------------------------
>
> Key: ZOOKEEPER-2399
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2399
> Project: ZooKeeper
> Issue Type: Improvement
> Reporter: William L Thomson Jr
> Priority: Major
> Attachments: ClientCnxnSocketNetty_java.patch,
> NettyServerCnxnFactory_java.patch, NettyServerCnxn_java.patch
>
>
> These are initial patches to update Zookeeper to Netty 4.x API. They are not
> complete, as I am not familiar with Zookeeper or Netty. I just used Netty
> documents that detailed the difference in the API to make the changes. I
> believe I am 80-90% of the way there, but need someone familiar with
> Zookeeper and/or Netty to finish the last part and make sure it actually
> works and I did not fubar Zookeeper :)
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
