[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16394725#comment-16394725
 ] 

ASF GitHub Bot commented on ZOOKEEPER-2993:
-------------------------------------------

GitHub user asutosh936 opened a pull request:

    https://github.com/apache/zookeeper/pull/488

    ZOOKEEPER-2993 - Removed 'generated' line from .gitignore

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/asutosh936/zookeeper ZOOKEEPER-2993

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zookeeper/pull/488.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #488
    
----
commit a02ef3db8d18cc738a1a3e24eafcaa0b5379d297
Author: asutosh936 <asutosh.pandya@...>
Date:   2018-02-25T23:40:14Z

    ZOOKEEPER-2936 - Removed duplicate code

commit 6a17613be090835286f6fd15b3fb5c40e269a25f
Author: asutosh936 <asutosh.pandya@...>
Date:   2018-03-01T01:22:30Z

    ZOOKEEPER-2936 - Deleted duplicate code

commit ad55832eafbe4e341e113a1bdeb0385674025b8e
Author: asutosh936 <asutosh.pandya@...>
Date:   2018-03-03T18:09:01Z

    Merge branch 'master' of https://github.com/apache/zookeeper

commit 67d454b5ab91b72f20b878c90c7d9f7a45bcdf88
Author: asutosh936 <asutosh.pandya@...>
Date:   2018-03-07T01:39:40Z

    Merge branch 'master' of https://github.com/apache/zookeeper

commit 13f8a235bad6f361120babf96f05aa2fc0cdcdb0
Author: asutosh936 <asutosh.pandya@...>
Date:   2018-03-12T01:06:57Z

    ZOOKEEPER-2993 - Removed 'generated' line from .gitignore

----


> .ignore file prevents adding src/java/main/org/apache/jute/compiler/generated 
> dir to git repo
> ---------------------------------------------------------------------------------------------
>
>                 Key: ZOOKEEPER-2993
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2993
>             Project: ZooKeeper
>          Issue Type: Bug
>          Components: build
>    Affects Versions: 3.4.10
>            Reporter: jason wang
>            Priority: Minor
>
> There are Rcc.java and other required files under the 
> src/java/main/org/apache/jute/compiler/generated directory.
> However, when I tried to add the source distribution to our own git repo, the 
> .gitignore file has "generated" as a key word in line 55 - which prevents the 
> dir and files under that dir to be added to the repo.  The compilation later 
> fails due to the missing dir and files.
> *compile_jute*
>  :*19:02:54* [mkdir] Created dir: 
> /home/jenkins/workspace/3PA/PMODS/zookeeper-pgdi-patch-in-maven-repo/src/java/generated*
> 19:02:54* [mkdir] Created dir: 
> /home/jenkins/workspace/3PA/PMODS/zookeeper-pgdi-patch-in-maven-repo/src/c/generated*
> 19:02:54* [java] Picked up JAVA_TOOL_OPTIONS: -Dfile.encoding=UTF8
> *19:02:54* [java] Error: Could not find or load main class 
> org.apache.jute.compiler.generated.Rcc*
> 19:02:54* [java] Java Result: 1*19:02:54* [java] Picked up JAVA_TOOL_OPTIONS: 
> -Dfile.encoding=UTF8
> *19:02:54* [java] Error: Could not find or load main class 
> org.apache.jute.compiler.generated.Rcc*
> 19:02:54* [java] Java Result: 1*19:02:54* [touch] Creating 
> /home/jenkins/workspace/3PA/PMODS/zookeeper-pgdi-patch-in-maven-repo/src/java/generated/.generated*
>  
> Fix is to remove or comment out the generated key word in line 55.
> #
>  #generated
>  #
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to