[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16397581#comment-16397581
 ] 

ASF GitHub Bot commented on ZOOKEEPER-2993:
-------------------------------------------

Github user afine commented on the issue:

    https://github.com/apache/zookeeper/pull/488
  
    > The change is to remove 'generated' keyword from .gitignore because it 
prevents the dir and files under generated dir to be added to the repo. The 
compilation later fails due to the missing dir and files.
    
    Which files are you referring to? I don't think we have any top level 
`generated` directory and I also don't think we would want to add such files to 
the repo.
    
    Don't worry about squashing, I should be able to take care of that when it 
comes time to commit.


> .ignore file prevents adding src/java/main/org/apache/jute/compiler/generated 
> dir to git repo
> ---------------------------------------------------------------------------------------------
>
>                 Key: ZOOKEEPER-2993
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2993
>             Project: ZooKeeper
>          Issue Type: Bug
>          Components: build
>    Affects Versions: 3.4.10
>            Reporter: jason wang
>            Priority: Minor
>
> There are Rcc.java and other required files under the 
> src/java/main/org/apache/jute/compiler/generated directory.
> However, when I tried to add the source distribution to our own git repo, the 
> .gitignore file has "generated" as a key word in line 55 - which prevents the 
> dir and files under that dir to be added to the repo.  The compilation later 
> fails due to the missing dir and files.
> *compile_jute*
>  :*19:02:54* [mkdir] Created dir: 
> /home/jenkins/workspace/3PA/PMODS/zookeeper-pgdi-patch-in-maven-repo/src/java/generated*
> 19:02:54* [mkdir] Created dir: 
> /home/jenkins/workspace/3PA/PMODS/zookeeper-pgdi-patch-in-maven-repo/src/c/generated*
> 19:02:54* [java] Picked up JAVA_TOOL_OPTIONS: -Dfile.encoding=UTF8
> *19:02:54* [java] Error: Could not find or load main class 
> org.apache.jute.compiler.generated.Rcc*
> 19:02:54* [java] Java Result: 1*19:02:54* [java] Picked up JAVA_TOOL_OPTIONS: 
> -Dfile.encoding=UTF8
> *19:02:54* [java] Error: Could not find or load main class 
> org.apache.jute.compiler.generated.Rcc*
> 19:02:54* [java] Java Result: 1*19:02:54* [touch] Creating 
> /home/jenkins/workspace/3PA/PMODS/zookeeper-pgdi-patch-in-maven-repo/src/java/generated/.generated*
>  
> Fix is to remove or comment out the generated key word in line 55.
> #
>  #generated
>  #
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to