-1 because release note is not correct. ZOOKEEPER-2948 and ZOOKEEPER-2806 should be included in release notes and corresponding JIRA needs update.
Other than this, rc0 looks good. - verified xsum/sig - go through release notes. - verified cluster with different sizes. - verified with few 4lw commands. - verified data / log dir swap was fixed. - all unit test passed. On Fri, Mar 23, 2018 at 1:23 PM, Ted Yu <yuzhih...@gmail.com> wrote: > I just ran the test suite again - there was no test failure. > > So +1 from my side. > > On Fri, Mar 23, 2018 at 9:54 AM, Abraham Fine <af...@apache.org> wrote: > > > Do they always fail when run with the rest of the test suite or is it > > inconsistent? > > > > The reason I ask is that the failure you are reporting is a > ConnectionLoss > > and testSessionTimeout has a history of being flaky (generally on > ZooKeeper > > 3.5 though). > > > > > > On Fri, Mar 23, 2018, at 09:45, Ted Yu wrote: > > > Here is OS: > > > > > > Linux h.com 3.10.0-327.28.3.el7.x86_64 #1 SMP Thu Aug 18 19:05:49 UTC > > 2016 > > > x86_64 x86_64 x86_64 GNU/Linux > > > > > > java version "1.8.0_161" > > > Java(TM) SE Runtime Environment (build 1.8.0_161-b12) > > > Java HotSpot(TM) 64-Bit Server VM (build 25.161-b12, mixed mode) > > > > > > The tests don't fail when run alone. > > > > > > FYI > > > > > > On Fri, Mar 23, 2018 at 9:41 AM, Abraham Fine <af...@apache.org> > wrote: > > > > > > > Hi Ted- > > > > > > > > Thanks for running the test cases on the RC. I am not able to > reproduce > > > > the failures. Would you mind telling us a little bit more about the > > > > environment you are running the tests in (operating system, jvm)? In > > > > addition, to the failures occur every time you run the tests or just > > > > occasionally? > > > > > > > > Thanks, > > > > Abe > > > > > > > > On Thu, Mar 22, 2018, at 17:16, Ted Yu wrote: > > > > > Hi, > > > > > I ran test suite for the RC. > > > > > > > > > > Testcase: testSessionTimeout took 22.686 sec > > > > > Caused an ERROR > > > > > KeeperErrorCode = ConnectionLoss for /stest > > > > > org.apache.zookeeper.KeeperException$ConnectionLossException: > > > > > KeeperErrorCode = ConnectionLoss for /stest > > > > > at org.apache.zookeeper.KeeperException.create( > > > > KeeperException.java:102) > > > > > at org.apache.zookeeper.KeeperException.create( > > > > KeeperException.java:54) > > > > > at org.apache.zookeeper.ZooKeeper.exists(ZooKeeper.java:1105) > > > > > at org.apache.zookeeper.ZooKeeper.exists(ZooKeeper.java:1133) > > > > > at > > > > > org.apache.zookeeper.test.SessionTest.testSessionTimeout( > > > > SessionTest.java:300) > > > > > > > > > > -------- > > > > > > > > > > Testcase: testWatcherAutoResetDisabledWithLocal took 8.545 sec > > > > > Caused an ERROR > > > > > KeeperErrorCode = ConnectionLoss for /watchtest/child2 > > > > > org.apache.zookeeper.KeeperException$ConnectionLossException: > > > > > KeeperErrorCode = ConnectionLoss for /watchtest/child2 > > > > > at > > > > > org.apache.zookeeper.KeeperException.create( > > KeeperException.java:102) > > > > > at > > > > > org.apache.zookeeper.KeeperException.create( > KeeperException.java:54) > > > > > at org.apache.zookeeper.ZooKeeper.delete(ZooKeeper.java:876) > > > > > at > > > > > org.apache.zookeeper.test.WatcherTest.testWatcherAutoReset( > > > > WatcherTest.java:369) > > > > > at > > > > > org.apache.zookeeper.test.WatcherTest. > testWatcherAutoResetWithLocal( > > > > WatcherTest.java:255) > > > > > at > > > > > org.apache.zookeeper.test.WatcherTest. > testWatcherAutoResetDisabledWi > > > > thLocal(WatcherTest.java:268) > > > > > > > > > > Has anyone else seen the above test failures ? > > > > > > > > > > Cheers > > > > > > >