[
https://issues.apache.org/jira/browse/ZOOKEEPER-2999?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16413410#comment-16413410
]
ASF GitHub Bot commented on ZOOKEEPER-2999:
-------------------------------------------
Github user andschwa commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/486#discussion_r176987184
--- Diff: src/c/CMakeLists.txt ---
@@ -14,14 +14,13 @@
# See the License for the specific language governing permissions and
# limitations under the License.
-cmake_minimum_required(VERSION 3.6)
+cmake_minimum_required(VERSION 3.5)
--- End diff --
I guess this needs a rebase now.
> CMake build should use target-level commands
> --------------------------------------------
>
> Key: ZOOKEEPER-2999
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2999
> Project: ZooKeeper
> Issue Type: Improvement
> Affects Versions: 3.6.0
> Reporter: Andrew Schwartzmeyer
> Assignee: Andrew Schwartzmeyer
> Priority: Minor
>
> Originally suggested in [GitHub PR
> #386|https://github.com/apache/zookeeper/pull/386], the CMake build I wrote
> used {{include_directories}}, which has global side effects, instead of the
> more explicit {{target_include_directories}}, to include directories per
> target (and with private or public scoping).
> Furthermore, it should also use {{CMAKE_CURRENT_SOURCE_DIR}} over
> {{CMAKE_SOURCE_DIR}} in order to allow inclusion in other projects via
> {{add_subdirectory()}}, and we can reduce the minimally required CMake
> version to 3.5 from 3.6.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
