[
https://issues.apache.org/jira/browse/ZOOKEEPER-2999?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16431396#comment-16431396
]
ASF GitHub Bot commented on ZOOKEEPER-2999:
-------------------------------------------
Github user andschwa commented on the issue:
https://github.com/apache/zookeeper/pull/486
@anmolnar So here's what failed on Jenkins, but it makes no sense because
Jenkins doesn't even use CMake. It can't be related:
```
[exec] [exec]
/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/src/c/tests/TestReconfig.cc:577:
Assertion: assertion failed [Expression: numClientsPerHost.at(i) <=
upperboundClientsPerServer(numClients, numServers)]
[exec] [exec] Failures !!!
[exec] [exec] Run: 37 Failure total: 1 Failures: 1 Errors: 0
[exec] [exec] FAIL: zktest-st
```
> CMake build should use target-level commands
> --------------------------------------------
>
> Key: ZOOKEEPER-2999
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2999
> Project: ZooKeeper
> Issue Type: Improvement
> Affects Versions: 3.6.0
> Reporter: Andrew Schwartzmeyer
> Assignee: Andrew Schwartzmeyer
> Priority: Minor
>
> Originally suggested in [GitHub PR
> #386|https://github.com/apache/zookeeper/pull/386], the CMake build I wrote
> used {{include_directories}}, which has global side effects, instead of the
> more explicit {{target_include_directories}}, to include directories per
> target (and with private or public scoping).
> Furthermore, it should also use {{CMAKE_CURRENT_SOURCE_DIR}} over
> {{CMAKE_SOURCE_DIR}} in order to allow inclusion in other projects via
> {{add_subdirectory()}}, and we can reduce the minimally required CMake
> version to 3.5 from 3.6.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
