Github user enixon commented on a diff in the pull request:

    https://github.com/apache/zookeeper/pull/476#discussion_r182175483
  
    --- Diff: 
src/java/main/org/apache/zookeeper/server/quorum/FastLeaderElection.java ---
    @@ -927,10 +927,11 @@ public Vote lookForLeader() throws 
InterruptedException {
                                 tmpTimeOut : maxNotificationInterval);
                         LOG.info("Notification time out: " + notTimeout);
                     } 
    -                else if 
(self.getCurrentAndNextConfigVoters().contains(n.sid)) {
    +                else if 
(self.getCurrentAndNextConfigVoters().contains(n.sid) &&
    --- End diff --
    
    There are five uses of `getCurrentAndNextConfigVoters().contains` in the 
class, seems reasonable to make it a method.


---

Reply via email to