Github user afine commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/476#discussion_r171972767
--- Diff:
src/java/main/org/apache/zookeeper/server/quorum/FastLeaderElection.java ---
@@ -1064,7 +1065,12 @@ else if
(self.getCurrentAndNextConfigVoters().contains(n.sid)) {
break;
}
} else {
- LOG.warn("Ignoring notification from non-cluster
member " + n.sid);
+ if
(!self.getCurrentAndNextConfigVoters().contains(n.leader)) {
+ LOG.warn("Ignoring notification for non-cluster
member sid {} from sid {}", n.leader, n.sid);
+ }
+ if
(!self.getCurrentAndNextConfigVoters().contains(n.sid)) {
+ LOG.warn("Ignoring notification from non-cluster
member sid {}", n.sid);
--- End diff --
nit: lets say "quorum" instead of "cluster"
---
