[
https://issues.apache.org/jira/browse/ZOOKEEPER-3019?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16449066#comment-16449066
]
ASF GitHub Bot commented on ZOOKEEPER-3019:
-------------------------------------------
Github user phunt commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/501#discussion_r183573019
--- Diff: src/java/test/org/apache/zookeeper/test/FourLetterWordsTest.java
---
@@ -167,6 +167,8 @@ public void testValidateStatOutput() throws Exception {
line = in.readLine();
Assert.assertTrue(Pattern.matches("^Mode: .*$", line));
line = in.readLine();
+ Assert.assertTrue(Pattern.matches("^Fsync threshold exceeded:
\\d+$", line));
--- End diff --
any chance we can add this to the very end of the output? We weren't very
clear on order and in some cases existing monitoring may be expecting the
original order. Appending helps wrt b/w compat.
> Add a metric to track number of slow fsyncs
> -------------------------------------------
>
> Key: ZOOKEEPER-3019
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3019
> Project: ZooKeeper
> Issue Type: Improvement
> Components: jmx, server
> Affects Versions: 3.5.3, 3.4.11, 3.6.0
> Reporter: Norbert Kalmar
> Assignee: Norbert Kalmar
> Priority: Major
> Fix For: 3.5.4, 3.6.0, 3.4.13
>
>
> Add jmx bean and Command to ZooKeeper server to expose the the number of slow
> fsyncs as a metric.
> FileTxnLog.commit() should count the number of times fsync exceedsÂ
> fsyncWarningThresholdMS.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
