[
https://issues.apache.org/jira/browse/ZOOKEEPER-3019?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16451387#comment-16451387
]
ASF GitHub Bot commented on ZOOKEEPER-3019:
-------------------------------------------
Github user phunt commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/501#discussion_r183907088
--- Diff: src/java/test/org/apache/zookeeper/test/FourLetterWordsTest.java
---
@@ -167,6 +167,8 @@ public void testValidateStatOutput() throws Exception {
line = in.readLine();
Assert.assertTrue(Pattern.matches("^Mode: .*$", line));
line = in.readLine();
+ Assert.assertTrue(Pattern.matches("^Fsync threshold exceeded:
\\d+$", line));
--- End diff --
That's pretty ugly, esp. if there are changes in the future.
Given the Monitor command is available since 3.4.0 and handles (documented)
such changes correctly perhaps we should just add this to monitor and not add
it to stat. If a user wants the additional information they can use mntr
instead.
What do you think @nkalmar ?
The other benefit is that it will integrate into 3.4 more easily - i.e.
fully b/w compat w/o any worries.
> Add a metric to track number of slow fsyncs
> -------------------------------------------
>
> Key: ZOOKEEPER-3019
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3019
> Project: ZooKeeper
> Issue Type: Improvement
> Components: jmx, server
> Affects Versions: 3.5.3, 3.4.11, 3.6.0
> Reporter: Norbert Kalmar
> Assignee: Norbert Kalmar
> Priority: Major
> Fix For: 3.5.4, 3.6.0, 3.4.13
>
>
> Add jmx bean and Command to ZooKeeper server to expose the the number of slow
> fsyncs as a metric.
> FileTxnLog.commit() should count the number of times fsync exceedsÂ
> fsyncWarningThresholdMS.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
