Github user anmolnar commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/561#discussion_r200985422
--- Diff: src/java/main/org/apache/zookeeper/server/ZooKeeperServer.java ---
@@ -1047,14 +1047,19 @@ public void processConnectRequest(ServerCnxn cnxn,
ByteBuffer incomingBuffer) th
cnxn.disableRecv();
long sessionId = connReq.getSessionId();
if (sessionId == 0) {
- LOG.info("Client attempting to establish new session at "
- + cnxn.getRemoteSocketAddress());
- createSession(cnxn, passwd, sessionTimeout);
+ long id = createSession(cnxn, passwd, sessionTimeout);
+ LOG.info("Client attempting to establish new session: session
= 0x"
--- End diff --
I like these ones. Would you please use the message formatter of the
logging lib? e.g. `"... {}... {}", a,b`
---
