Github user breed commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/561#discussion_r201304775
--- Diff: src/java/main/org/apache/zookeeper/server/ZooKeeperServer.java ---
@@ -1047,14 +1047,19 @@ public void processConnectRequest(ServerCnxn cnxn,
ByteBuffer incomingBuffer) th
cnxn.disableRecv();
long sessionId = connReq.getSessionId();
if (sessionId == 0) {
- LOG.info("Client attempting to establish new session at "
- + cnxn.getRemoteSocketAddress());
- createSession(cnxn, passwd, sessionTimeout);
+ long id = createSession(cnxn, passwd, sessionTimeout);
+ LOG.info("Client attempting to establish new session: session
= 0x"
+ + Long.toHexString(id)
+ + ", zxid = 0x" +
Long.toHexString(connReq.getLastZxidSeen())
+ + ", timeout = " + connReq.getTimeOut()
+ + ", address = " + cnxn.getRemoteSocketAddress());
} else {
long clientSessionId = connReq.getSessionId();
- LOG.info("Client attempting to renew session 0x"
+ LOG.info("Client attempting to renew session: session = 0x"
--- End diff --
i feel this should be debug as well.
---
