[
https://issues.apache.org/jira/browse/ZOOKEEPER-3181?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16661792#comment-16661792
]
Mohammad Arshad commented on ZOOKEEPER-3181:
--------------------------------------------
Thanks [~ajisakaa] for bringing this issue to our notice
getQuorumPeer method was added to inject custom QuorumPeer in test classes. I
think adding this method does not violate any backward compatibility
requirement. It is completely co-incident that curator had exactly same method
name.
I see you have changed method name in curator to getTestingQuorumPeer.
What change you want to see in ZooKeeper. Do you want to rename getQuorumPeer
method to something else.
> ZOOKEEPER-2355 broke Curator TestingQuorumPeerMain
> --------------------------------------------------
>
> Key: ZOOKEEPER-3181
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3181
> Project: ZooKeeper
> Issue Type: Bug
> Affects Versions: 3.5.3, 3.4.11
> Reporter: Akira Ajisaka
> Priority: Major
>
> ZOOKEEPER-2355 added a getQuorumPeer method to QuorumPeerMainÂ
> [https://github.com/apache/zookeeper/blob/release-3.5.3/src/java/main/org/apache/zookeeper/server/quorum/QuorumPeerMain.java#L194].
> TestingQuorumPeerMain has an identically named method, which is now
> unintentionally overridding the one in the base class.
> This is fixed by CURATOR-409, however, I'd like this to be fixed in ZooKeeper
> as well.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
