[
https://issues.apache.org/jira/browse/ZOOKEEPER-3181?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16666708#comment-16666708
]
Akira Ajisaka commented on ZOOKEEPER-3181:
------------------------------------------
bq. Shall I check before creating new method whether same method is available
or not in the downstream projects? I don’t think this is logical thing.
Agreed.
bq. Any thoughts on how to avoid this kind of issues in future?
IMO, if using module, we can avoid this kind of issues in future.
http://openjdk.java.net/projects/jigsaw/
> ZOOKEEPER-2355 broke Curator TestingQuorumPeerMain
> --------------------------------------------------
>
> Key: ZOOKEEPER-3181
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3181
> Project: ZooKeeper
> Issue Type: Bug
> Affects Versions: 3.5.3, 3.4.11
> Reporter: Akira Ajisaka
> Priority: Major
> Labels: pull-request-available
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
> ZOOKEEPER-2355 added a getQuorumPeer method to QuorumPeerMainÂ
> [https://github.com/apache/zookeeper/blob/release-3.5.3/src/java/main/org/apache/zookeeper/server/quorum/QuorumPeerMain.java#L194].
> TestingQuorumPeerMain has an identically named method, which is now
> unintentionally overridding the one in the base class.
> This is fixed by CURATOR-409, however, I'd like this to be fixed in ZooKeeper
> as well.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
