[GitHub] zookeeper pull request #700: ZOOKEEPER-1441 - JAVA 11 - Some test cases are ...

[eolivelli]

Github user eolivelli commented on a diff in the pull request:

    https://github.com/apache/zookeeper/pull/700#discussion_r232832500
  
    --- Diff: 
zookeeper-server/src/main/java/org/apache/zookeeper/server/NIOServerCnxnFactory.java
 ---
    @@ -181,7 +181,7 @@ protected void fastCloseSock(SocketChannel sc) {
          */
         private class AcceptThread extends AbstractSelectThread {
             private final ServerSocketChannel acceptSocket;
    -        private final SelectionKey acceptKey;
    +        private SelectionKey acceptKey;
    --- End diff --
    
    Now this variable is nullable.
    Shouldn't we add some null check at every access?


---