Github user anmolnar commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/700#discussion_r232840801
--- Diff:
zookeeper-server/src/main/java/org/apache/zookeeper/server/NIOServerCnxnFactory.java
---
@@ -181,7 +181,7 @@ protected void fastCloseSock(SocketChannel sc) {
*/
private class AcceptThread extends AbstractSelectThread {
private final ServerSocketChannel acceptSocket;
- private final SelectionKey acceptKey;
+ private SelectionKey acceptKey;
--- End diff --
You're right. However the only access in this class is called from the
`select()` method which is called only after the registration is successful, so
I think we're fine.
---
