ivmaykov commented on a change in pull request #753: ZOOKEEPER-3204: Reconfig
tests are constantly failing on 3.5 after applying Java 11 fix
URL: https://github.com/apache/zookeeper/pull/753#discussion_r253221008
##########
File path:
zookeeper-server/src/main/java/org/apache/zookeeper/server/NettyServerCnxn.java
##########
@@ -303,19 +277,126 @@ private boolean checkFourLetterWord(final Channel
channel,
}
}
- public void receiveMessage(ChannelBuffer message) {
+ /**
+ * Process incoming message. This should only be called from the event
+ * loop thread.
+ * @param buf the message bytes to process.
+ */
+ void processMessage(ByteBuf buf) {
+ assert channel.eventLoop().inEventLoop();
Review comment:
nit: in our internal fork, we changed these asserts to if-throws (I forgot
to upstream this change, will do it on master branch shortly). I don't think it
matters that much since they've never fired. Anyway, what do you think about
replacing this assert with:
```
if (!channel.eventLoop().inEventLoop()) {
throw new IllegalStateException(
"processMessage() called from non-EventLoop thread");
}
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
