ivmaykov commented on a change in pull request #753: ZOOKEEPER-3204: Reconfig
tests are constantly failing on 3.5 after applying Java 11 fix
URL: https://github.com/apache/zookeeper/pull/753#discussion_r254329710
##########
File path: zookeeper-server/pom.xml
##########
@@ -69,7 +69,7 @@
</dependency>
<dependency>
<groupId>io.netty</groupId>
- <artifactId>netty</artifactId>
+ <artifactId>netty-all</artifactId>
Review comment:
We actually had that originally, but a reviewer told me to depend on
netty-all instead for simplicity. Assuming disk usage is not an issue, are
there any runtime advantages in depending on only the used sub-artifacts?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
