normanmaurer commented on a change in pull request #753: ZOOKEEPER-3204:
Reconfig tests are constantly failing on 3.5 after applying Java 11 fix
URL: https://github.com/apache/zookeeper/pull/753#discussion_r254184185
##########
File path:
zookeeper-server/src/main/java/org/apache/zookeeper/ClientCnxnSocketNetty.java
##########
@@ -291,33 +355,36 @@ private void doWrite(List<Packet> pendingQueue, Packet
p, ClientCnxn cnxn) {
pendingQueue.add(p);
}
}
- sendPkt(p);
+ sendPktOnly(p);
}
if (outgoingQueue.isEmpty()) {
break;
}
p = outgoingQueue.remove();
}
+ // TODO: maybe we should flush in the loop above every N packets/bytes?
+ // But, how do we determine the right value for N ...
+ channel.flush();
Review comment:
you may at least want to consider only calling `flush()` if the queue was
not empty.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
