normanmaurer commented on a change in pull request #753: ZOOKEEPER-3204:
Reconfig tests are constantly failing on 3.5 after applying Java 11 fix
URL: https://github.com/apache/zookeeper/pull/753#discussion_r254176555
##########
File path:
zookeeper-server/src/main/java/org/apache/zookeeper/ClientCnxnSocketNetty.java
##########
@@ -185,7 +218,9 @@ void cleanup() {
@Override
void close() {
- channelFactory.releaseExternalResources();
+ if (!eventLoopGroup.isShuttingDown()) {
Review comment:
nit: there is no need for this... calling `shutdownGraceFully()` multiple
times is just fine
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
