BELUGABEHR commented on a change in pull request #823: ZOOKEEPER-2694:sync CLI
command does not wait for result from server
URL: https://github.com/apache/zookeeper/pull/823#discussion_r272170987
##########
File path:
zookeeper-server/src/main/java/org/apache/zookeeper/cli/SyncCommand.java
##########
@@ -30,6 +35,7 @@
private static Options options = new Options();
private String[] args;
+ public static final int CONNECTION_TIMEOUT = 30000;//30s
Review comment:
Please use TimeUnit so that it is self documenting.
https://docs.oracle.com/javase/7/docs/api/java/util/concurrent/TimeUnit.html
`TimeUnit.SECONDS.toMillis(30L)`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
