BELUGABEHR commented on a change in pull request #823: ZOOKEEPER-2694:sync CLI
command does not wait for result from server
URL: https://github.com/apache/zookeeper/pull/823#discussion_r272175265
##########
File path:
zookeeper-server/src/main/java/org/apache/zookeeper/cli/SyncCommand.java
##########
@@ -55,18 +61,27 @@ public CliCommand parse(String[] cmdArgs) throws
CliParseException {
@Override
public boolean exec() throws CliException {
String path = args[1];
+ CompletableFuture<Integer> cf = new CompletableFuture<>();
+
try {
zk.sync(path, new AsyncCallback.VoidCallback() {
-
public void processResult(int rc, String path, Object ctx) {
- out.println("Sync returned " + rc);
+ cf.complete(rc);
}
}, null);
+
+ try {
+ int resultCode = cf.get(CONNECTION_TIMEOUT,
TimeUnit.MILLISECONDS);
+ out.println("Sync returned " + resultCode);
+ } catch (TimeoutException ex) {
+ out.println("Sync is timeout within " + CONNECTION_TIMEOUT +
" ms");
+ }
} catch (IllegalArgumentException ex) {
throw new MalformedPathException(ex.getMessage());
+ } catch (InterruptedException | ExecutionException ex) {
Review comment:
When you catch the Interrupted exception, it clears the Thread's state. I
would separate the catch into two blocks and be sure to reinstate the flag to
'interrupted' so that any other code will also quickly exit.
```
} catch (InterruptedException ie) {
Thread.currentThread().interrupt();
throw new CliWrapperException(ie);
}
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
