Hi Enrico, Just my 2cents.
Having the sources jars in the binary package can be useful if you want to debug without downloading the source tarball or checking out the whole project from github. In the same time it is not needed on the classpath. The docs html is generated from md files now, but the design didn't get updated. I wanted to do it (to have the same design as the website), but never had time for that. It doesn't look a blocker for me, can be done in any release later. Regards, Tamaas On Fri, Apr 5, 2019, 17:37 Enrico Olivelli <[email protected]> wrote: > -1 (non binding) > > Good news: > I have build the sources with jdk-8 and all tests passed > checksums and signatures are ok > I run a few smoke tests running on JDK11, all is ok > > Bad news: > I see the following problems in the "binary package", not all blockers: > - we have a lib/cobertura directory, not useful > - we have zookeeper-3.5.5-sources.jar not needed in the "binary" > package on the classpath > - we also have all of the 'recipes' not needed in the "binary" package > on the classpath > - inside the "docs" directory I see a webside with a very old look and feel > > The source package does not reflect the repository, for instance > build.xml file, owaspSuppressions.xml, > excludeFindBugsFilter.xml.....are missing. > I think we have to release in a "source package" a clean copy of ASF > repository at the released "git tag" > > > Enrico > > Il giorno ven 5 apr 2019 alle ore 14:35 Andor Molnar > <[email protected]> ha scritto: > > > > This is the first stable release of 3.5 branch: 3.5.5. It resolves 117 > issues, including Maven migration, Quorum TLS, TTL nodes and lots of other > performance and stability improvements. > > > > The full release notes is available at: > > > > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310801&version=12343268 > > > > *** Please download, test and vote by April 12th 2019, 23:59 UTC+0. *** > > > > Source files: > > https://dist.apache.org/repos/dist/dev/zookeeper/zookeeper-3.5.5-rc2/ > > > > Maven staging repos: > > > https://repository.apache.org/content/groups/staging/org/apache/zookeeper/parent/3.5.5/ > > > https://repository.apache.org/content/groups/staging/org/apache/zookeeper/zookeeper-jute/3.5.5/ > > > https://repository.apache.org/content/groups/staging/org/apache/zookeeper/zookeeper/3.5.5/ > > > > The release candidate tag in git to be voted upon: release-3.5.5-rc2 > > > > ZooKeeper's KEYS file containing PGP keys we use to sign the release: > > http://www.apache.org/dist/zookeeper/KEYS > > > > Should we release this candidate? > > >
