TisonKun commented on a change in pull request #839: ZOOKEEPER-3290: Throw
detailed KeeperException when a transaction failed
URL: https://github.com/apache/zookeeper/pull/839#discussion_r279345374
##########
File path:
zookeeper-server/src/main/java/org/apache/zookeeper/server/DataTree.java
##########
@@ -946,7 +947,7 @@ public ProcessTxnResult processTxn(TxnHeader header,
Record txn, boolean isSubTx
: Code.OK.intValue();
subtxn.setType(OpCode.error);
- record = new ErrorTxn(ec);
+ record = new ErrorTxn(ec, "");
Review comment:
A question here maybe. Should we use `""` or `null` to stand for "no
meaningful path"? Now I prefer the later since it explicitly represent "non
value here".
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
