We should restore it as we did for ZKUtils#delete Both in 3.5x and in 3.6 We just ensure smooth upgrade
Enrico Il Mer 1 Apr 2020, 12:06 Norbert Kalmar <nkal...@cloudera.com.invalid> ha scritto: > Hi all, > > We removed the getRevision() [1] function in 3.5.6 [2]. > I just tried updating to ZooKeeper 3.5.7 in our system, but HBase is not > happy with this. It gets ZooKeeper's revision using this method. It is true > HBase could just move to using getRevisionHash, but they are still using > 3.4.x, and getRevisionHash is not available there. So I can't just move the > the new function to be both compatible with 3.4 and 3.5.6+, unfortunately. > > Long story short, we removed a public function in a bugfix release (in > 3.5.5 it is still there). > With 3.5.5 our internal system works fine, but can't build with 3.5.7 (or > 3.5.6) because of this change. > > My question: should we reinstate this function, and maybe do a 3.5.8 > release? Who knows who else runs into this problem. > Any thoughts? > > - Norbert > > [1] > > https://github.com/apache/zookeeper/commit/41da3c8e3c39f81aa0f667199c5f4eb3d5a28adc#diff-12bf6d03d211704a4f04cb234a20bf2aL23 > [2] > > https://github.com/apache/zookeeper/commit/96880c0b2ba39f1841f8bdc4a0119a467b462d03#diff-1d42dde48d42e3baf819e22b56a880a7 >
