+1. xsum/sig verified. compiled fine and I was able to run some manual test successfully. lgtm
Patrick On Thu, Apr 23, 2020 at 2:16 PM Christopher <ctubb...@apache.org> wrote: > +1 (non-binding); overall, looks great! > > Good: > * Source tarball matches tag (git sha1 at > 104dcb3e3fb464b30c5186d229e00af9f332524b) > * Release tag includes all commits from branch-3.6 (at > e64a74fabafeb3b20109014149beb3ebd6a48be7) > * SHA512 checksums match tarballs: > > 1c5cb4d9886fae41bf244a446dd874b73c0fff7a5fc2dda4305041964420cde21e59b388dfd2551464a46bb6918d9d3c3c01ebe68fdbe782074ee360aa830c7d > apache-zookeeper-3.6.1-bin.tar.gz > > 0c6740a14bcc6fac56ffa1d4d18dc5397d454d46ffb42a3f6a784a9d8bf5083b460d6f8a5f65718e83973f65683a420a4614de11710e21cdf288d586d3c5203d > apache-zookeeper-3.6.1.tar.gz > * GPG signatures match (signed using key > BBE7232D7991050B54C8EA0ADC08637CA615D22C, 2048/rsa, with recommended > SHA512 digest algo) and key is present in KEYS > * Was able to reproduce creation of the binary tarball (comparison of > file listing only) using OpenJDK14 (only diffs were expected javadoc > differences) using `mvn clean package -Pfull-build` > * I tested the convenience binary with Apache Accumulo 2.0.0 and basic > functionality is all there > > Of minor concern: > * Seeing lots of warnings in the ZK logs about bad reads from the > client connection when there hasn't been any other indication of a > failure anywhere. Possibly a mishandled connection in client code, but > not sure (certainly not serious enough to block a release, since > everything seems to be functioning fine otherwise): > 2020-04-23 17:01:48,414 [myid:] - WARN > [NIOWorkerThread-3:NIOServerCnxn@364] - Unexpected exception > EndOfStreamException: Unable to read additional data from client, it > probably closed the socket: address = /127.0.0.1:35702, session = > 0x100028c09f1000e > at > org.apache.zookeeper.server.NIOServerCnxn.handleFailedRead(NIOServerCnxn.java:163) > at org.apache.zookeeper.server.NIOServerCnxn.doIO(NIOServerCnxn.java:326) > at > org.apache.zookeeper.server.NIOServerCnxnFactory$IOWorkRequest.doWork(NIOServerCnxnFactory.java:522) > at > org.apache.zookeeper.server.WorkerService$ScheduledWorkRequest.run(WorkerService.java:154) > at > java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1130) > at > java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:630) > at java.base/java.lang.Thread.run(Thread.java:832) > > On Thu, Apr 23, 2020 at 6:00 AM Norbert Kalmar > <nkal...@cloudera.com.invalid> wrote: > > > > Sure, I'll do the update today. > > +1 (non-binding) from me (see my testing in my previous mail) > > > > Thanks Enrico! > > > > On Thu, Apr 23, 2020 at 11:20 AM Enrico Olivelli <eolive...@gmail.com> > > wrote: > > > > > Il giorno mer 22 apr 2020 alle ore 16:14 Norbert Kalmar > > > <nkal...@cloudera.com.invalid> ha scritto: > > > > > > > Only thing I found is that the bin has netty-codec-4.1.49 license > file > > > > while the jar included is 4.1.48. I think the license version has a > typo > > > in > > > > the bugfix version. Not sure if it's a showstopper. > > > > > > > > > > I don't consider it a showstopper. > > > > > > Do you have time to send a fix please ? > > > This way if we have to roll out a new RC we can pick it up. > > > > > > We could anyhow update to 4.1.49.Final > > > https://netty.io/news/2020/04/22/4-1-49-Final.html > > > > > > Enrico > > > > > > > > > > > > > > Otherwise LGTM: > > > > - Signatures OK > > > > - Compared to git and 3.6.0 > > > > - Compiled both on Mac (without C client) and Linux (with C client) > > > > - Run tests (from src) and server (from src and bin tarball), connect > > > with > > > > client and run simple commands > > > > - Spotbugs and checkstyle passed > > > > > > > > Regards, > > > > Norbert > > > > > > > > On Wed, Apr 22, 2020 at 3:50 PM Szalay-Bekő Máté < > > > > szalay.beko.m...@gmail.com> > > > > wrote: > > > > > > > > > +1 (non-binding) > > > > > > > > > > - I built the source code (-Pfull-build) on Ubuntu 18.04.3 using > > > OpenJDK > > > > > 8u242 and maven 3.6.0. > > > > > - all the unit tests passed (both Java and C-client). > > > > > - I also built and executed unit tests for zkpython > > > > > - checkstyle and spotbugs passed > > > > > - apache-rat passed > > > > > - fatjar built > > > > > - I executed a quick rolling-upgrade test from 3.5.7 to 3.6.1. > (using > > > > > https://github.com/symat/zk-rolling-upgrade-test) > > > > > > > > > > On Tue, Apr 21, 2020 at 5:20 PM Enrico Olivelli < > eolive...@gmail.com> > > > > > wrote: > > > > > > > > > > > This is a release candidate for 3.6.1. > > > > > > > > > > > > It is a bugfix release and it introduces a few bugfixes and new > > > > features > > > > > in > > > > > > these areas: > > > > > > - compatibility with applications built against 3.5 client > libraries > > > > > > (restored a few non public APIs) > > > > > > - update Netty to 4.1.48.Final > > > > > > - ability to pass configuration as file in zkCli for TLS config > > > > > > - Add setKeepAlive support for NIOServerCnxn > > > > > > - Fix server side request throttling > > > > > > > > > > > > The full release notes is available at: > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310801&version=12346764 > > > > > > > > > > > > *** Please download, test and vote by April 14th 2020, 23:59 > UTC+0. > > > *** > > > > > > > > > > > > Source files: > > > > > > > https://people.apache.org/~eolivelli/zookeeper-3.6.1-candidate-1/ > > > > > > > > > > > > Maven staging repo: > > > > > > > > > > > > > > > > > > > https://repository.apache.org/content/repositories/orgapachezookeeper-1058/ > > > > > > > > > > > > The release candidate tag in git to be voted upon: > release-3.6.1-1 > > > > > > https://github.com/apache/zookeeper/tree/release-3.6.1-1 > > > > > > > > > > > > ZooKeeper's KEYS file containing PGP keys we use to sign the > release: > > > > > > https://www.apache.org/dist/zookeeper/KEYS > > > > > > > > > > > > The staging version of the website is: > > > > > > > > > > > > > > > > > > > https://people.apache.org/~eolivelli/zookeeper-3.6.1-candidate-1/website/ > > > > > > > > > > > > Should we release this candidate? > > > > > > > > > > > > Enrico Olivelli > > > > > > > > > > > > > > > > > > >
