Reviewed-by: Chasel Chiu <[email protected]>
> -----Original Message----- > From: Gao, Zhichao > Sent: Friday, April 26, 2019 9:04 AM > To: [email protected] > Cc: Laszlo Ersek <[email protected]>; Kinney, Michael D > <[email protected]>; Gao, Liming <[email protected]>; Bi, > Dandan <[email protected]>; Chiu, Chasel <[email protected]>; > Desimone, Nathaniel L <[email protected]> > Subject: [PATCH V3 6/8] IntelFsp2WrapperPkg/FspWrapperNotifyDxe: make > global variable static > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1740 > > Add a 'static' storage-class specifier to the global variables that only used > in a > single file to minimize the name collisions. > This is only for the variable named 'mExitBootServicesEvent'. > > Cc: Laszlo Ersek <[email protected]> > Cc: Michael D Kinney <[email protected]> > Cc: Liming Gao <[email protected]> > Cc: Dandan Bi <[email protected]> > Signed-off-by: Zhichao Gao <[email protected]> > Reviewed-by: Chasel Chiu <[email protected]> > Reviewed-by: Nate DeSimone <[email protected]> > --- > IntelFsp2WrapperPkg/FspWrapperNotifyDxe/FspWrapperNotifyDxe.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git > a/IntelFsp2WrapperPkg/FspWrapperNotifyDxe/FspWrapperNotifyDxe.c > b/IntelFsp2WrapperPkg/FspWrapperNotifyDxe/FspWrapperNotifyDxe.c > index fe344a5327..0af0ec778c 100644 > --- a/IntelFsp2WrapperPkg/FspWrapperNotifyDxe/FspWrapperNotifyDxe.c > +++ b/IntelFsp2WrapperPkg/FspWrapperNotifyDxe/FspWrapperNotifyDxe.c > @@ -1,7 +1,7 @@ > /** @file > This driver will register two callbacks to call fsp's notifies. > > - Copyright (c) 2014 - 2016, Intel Corporation. All rights reserved.<BR> > + Copyright (c) 2014 - 2019, Intel Corporation. All rights > + reserved.<BR> > SPDX-License-Identifier: BSD-2-Clause-Patent > > **/ > @@ -39,7 +39,7 @@ extern EFI_GUID gAddPerfRecordProtocolGuid; extern > EFI_GUID gFspHobGuid; extern EFI_GUID gFspApiPerformanceGuid; > > -EFI_EVENT mExitBootServicesEvent = NULL; > +static EFI_EVENT mExitBootServicesEvent = NULL; > > /** > Relocate this image under 4G memory. > -- > 2.21.0.windows.1 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#39605): https://edk2.groups.io/g/devel/message/39605 Mute This Topic: https://groups.io/mt/31348683/21656 Group Owner: [email protected] Unsubscribe: https://edk2.groups.io/g/devel/unsub [[email protected]] -=-=-=-=-=-=-=-=-=-=-=-
