> -----Original Message----- > From: Gao, Zhichao > Sent: Friday, April 26, 2019 9:04 AM > To: devel@edk2.groups.io > Cc: Laszlo Ersek; Wang, Jian J; Wu, Hao A; Ni, Ray; Zeng, Star; Gao, Liming; > Bi, > Dandan > Subject: [PATCH V3 8/8] MdeModulePkg/StatusCodeHandlerRuntimeDxe: make > global variable static
Similar comment as patch 5/8. But I will leave the decision to you. Reviewed-by: Hao Wu <hao.a...@intel.com> Best Regards, Hao Wu > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1740 > > Add a 'static' storage-class specifier to the global variables > that only used in a single file to minimize the name collisions. > This is only for the variable named 'mExitBootServicesEvent'. > > Cc: Laszlo Ersek <ler...@redhat.com> > Cc: Jian J Wang <jian.j.w...@intel.com> > Cc: Hao Wu <hao.a...@intel.com> > Cc: Ray Ni <ray...@intel.com> > Cc: Star Zeng <star.z...@intel.com> > Cc: Liming Gao <liming....@intel.com> > Cc: Dandan Bi <dandan...@intel.com> > Signed-off-by: Zhichao Gao <zhichao....@intel.com> > --- > .../RuntimeDxe/StatusCodeHandlerRuntimeDxe.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git > a/MdeModulePkg/Universal/StatusCodeHandler/RuntimeDxe/StatusCodeHandl > erRuntimeDxe.c > b/MdeModulePkg/Universal/StatusCodeHandler/RuntimeDxe/StatusCodeHandl > erRuntimeDxe.c > index 0d327d40e3..79cc48fa55 100644 > --- > a/MdeModulePkg/Universal/StatusCodeHandler/RuntimeDxe/StatusCodeHandl > erRuntimeDxe.c > +++ > b/MdeModulePkg/Universal/StatusCodeHandler/RuntimeDxe/StatusCodeHandl > erRuntimeDxe.c > @@ -2,7 +2,7 @@ > Status Code Handler Driver which produces general handlers and hook them > onto the DXE status code router. > > - Copyright (c) 2006 - 2018, Intel Corporation. All rights reserved.<BR> > + Copyright (c) 2006 - 2019, Intel Corporation. All rights reserved.<BR> > SPDX-License-Identifier: BSD-2-Clause-Patent > > **/ > @@ -10,7 +10,7 @@ > #include "StatusCodeHandlerRuntimeDxe.h" > > EFI_EVENT mVirtualAddressChangeEvent = NULL; > -EFI_EVENT mExitBootServicesEvent = NULL; > +static EFI_EVENT mExitBootServicesEvent = NULL; > EFI_RSC_HANDLER_PROTOCOL *mRscHandlerProtocol = NULL; > > /** > -- > 2.21.0.windows.1 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#39628): https://edk2.groups.io/g/devel/message/39628 Mute This Topic: https://groups.io/mt/31348685/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
