Reviewed-by: Liming Gao <[email protected]> >-----Original Message----- >From: Laszlo Ersek [mailto:[email protected]] >Sent: Saturday, April 27, 2019 3:38 AM >To: Gao, Zhichao <[email protected]>; [email protected] >Cc: Wang, Jian J <[email protected]>; Wu, Hao A <[email protected]>; >Ni, Ray <[email protected]>; Zeng, Star <[email protected]>; Kinney, >Michael D <[email protected]>; Gao, Liming ><[email protected]>; Bi, Dandan <[email protected]> >Subject: Re: [PATCH V3 0/8] make mExitBootServicesEvent static > >On 04/26/19 03:03, Zhichao Gao wrote: >> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1740 >> >> V1: >> The DebugLib instances of DebugPortProtocol, ConOut and StdErr >> use a global variable "mExitBootServicesEvent" which is in >> conflict with the same variable in StatusCodeHandlerRuntimeDxe.inf. >> That would cause a build error through GCC5. So change the >> name to the "mDebugLibExitBootServicesEvent". >> >> V2: >> Abandon v1. >> Add a 'static' descriptor to the global variables that only >> used in a single file to minimize the name collisions. >> This is only for the variable named 'mExitBootServicesEvent'. >> >> V3: >> Update the commit message and some copyright date. >> >> Cc: Laszlo Ersek <[email protected]> >> Cc: Jian J Wang <[email protected]> >> Cc: Hao Wu <[email protected]> >> Cc: Ray Ni <[email protected]> >> Cc: Star Zeng <[email protected]> >> Cc: Michael D Kinney <[email protected]> >> Cc: Liming Gao <[email protected]> >> Cc: Dandan Bi <[email protected]> >> >> Zhichao Gao (8): >> MdePkg/UefiDebugLibConOut: make global variable static >> MdePkg/UefiDebugLibDebugPortProtocol: make global variable static >> MdePkg/UefiDebugLibStdErr: make global variable static >> IntelFrameworkModulePkg: make global variable static >> MdeModulePkg/FirmwarePerformanceDxe: make global variable static >> IntelFsp2WrapperPkg/FspWrapperNotifyDxe: make global variable static >> IntelFrameworkModulePkg: make global variable static >> MdeModulePkg/StatusCodeHandlerRuntimeDxe: make global variable >static >> >> .../SmmRuntimeDxeSupport.c | 4 ++-- >> .../DatahubStatusCodeHandlerDxe/DatahubStatusCodeHandlerDxe.c | 4 >++-- >> IntelFsp2WrapperPkg/FspWrapperNotifyDxe/FspWrapperNotifyDxe.c | 4 >++-- >> .../FirmwarePerformanceDataTableDxe/FirmwarePerformanceDxe.c | 4 >++-- >> .../RuntimeDxe/StatusCodeHandlerRuntimeDxe.c | 4 ++-- >> MdePkg/Library/UefiDebugLibConOut/DebugLibConstructor.c | 2 +- >> .../UefiDebugLibDebugPortProtocol/DebugLibConstructor.c | 2 +- >> MdePkg/Library/UefiDebugLibStdErr/DebugLibConstructor.c | 2 +- >> 8 files changed, 13 insertions(+), 13 deletions(-) >> > >series >Reviewed-by: Laszlo Ersek <[email protected]>
-=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#39704): https://edk2.groups.io/g/devel/message/39704 Mute This Topic: https://groups.io/mt/31348674/21656 Group Owner: [email protected] Unsubscribe: https://edk2.groups.io/g/devel/unsub [[email protected]] -=-=-=-=-=-=-=-=-=-=-=-
