On 04/26/19 03:03, Zhichao Gao wrote: > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1740 > > V1: > The DebugLib instances of DebugPortProtocol, ConOut and StdErr > use a global variable "mExitBootServicesEvent" which is in > conflict with the same variable in StatusCodeHandlerRuntimeDxe.inf. > That would cause a build error through GCC5. So change the > name to the "mDebugLibExitBootServicesEvent". > > V2: > Abandon v1. > Add a 'static' descriptor to the global variables that only > used in a single file to minimize the name collisions. > This is only for the variable named 'mExitBootServicesEvent'. > > V3: > Update the commit message and some copyright date. > > Cc: Laszlo Ersek <ler...@redhat.com> > Cc: Jian J Wang <jian.j.w...@intel.com> > Cc: Hao Wu <hao.a...@intel.com> > Cc: Ray Ni <ray...@intel.com> > Cc: Star Zeng <star.z...@intel.com> > Cc: Michael D Kinney <michael.d.kin...@intel.com> > Cc: Liming Gao <liming....@intel.com> > Cc: Dandan Bi <dandan...@intel.com> > > Zhichao Gao (8): > MdePkg/UefiDebugLibConOut: make global variable static > MdePkg/UefiDebugLibDebugPortProtocol: make global variable static > MdePkg/UefiDebugLibStdErr: make global variable static > IntelFrameworkModulePkg: make global variable static > MdeModulePkg/FirmwarePerformanceDxe: make global variable static > IntelFsp2WrapperPkg/FspWrapperNotifyDxe: make global variable static > IntelFrameworkModulePkg: make global variable static > MdeModulePkg/StatusCodeHandlerRuntimeDxe: make global variable static > > .../SmmRuntimeDxeSupport.c | 4 ++-- > .../DatahubStatusCodeHandlerDxe/DatahubStatusCodeHandlerDxe.c | 4 ++-- > IntelFsp2WrapperPkg/FspWrapperNotifyDxe/FspWrapperNotifyDxe.c | 4 ++-- > .../FirmwarePerformanceDataTableDxe/FirmwarePerformanceDxe.c | 4 ++-- > .../RuntimeDxe/StatusCodeHandlerRuntimeDxe.c | 4 ++-- > MdePkg/Library/UefiDebugLibConOut/DebugLibConstructor.c | 2 +- > .../UefiDebugLibDebugPortProtocol/DebugLibConstructor.c | 2 +- > MdePkg/Library/UefiDebugLibStdErr/DebugLibConstructor.c | 2 +- > 8 files changed, 13 insertions(+), 13 deletions(-) >
series Reviewed-by: Laszlo Ersek <ler...@redhat.com> -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#39663): https://edk2.groups.io/g/devel/message/39663 Mute This Topic: https://groups.io/mt/31348674/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
